Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42821 )
Change subject: soc/intel/tigerlake: Add platform wide _OSC capabilities for USB4 ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/42821/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42821/2//COMMIT_MSG@11 PS2, Line 11: 6.2.11.1.13 I don't see a 6.2.11.1.13 in the latest published spec (https://uefi.org/sites/default/files/resources/ACPI_6_3_May16.pdf), could that possibly be 6.2.11.2, "Platform-wide OSPM Capabilities" ?
https://review.coreboot.org/c/coreboot/+/42821/2//COMMIT_MSG@10 PS2, Line 10: There is Engineering Change Request (ECR) with _OSC addition : for OSPM USB support. ACPI section 6.2.11.1.13 is modified with bit 18 : as native USB4 support. Is this ECR published anywhere?
https://review.coreboot.org/c/coreboot/+/42821/2//COMMIT_MSG@16 PS2, Line 16: fixs fixes
https://review.coreboot.org/c/coreboot/+/42821/2/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/tcss.asl:
https://review.coreboot.org/c/coreboot/+/42821/2/src/soc/intel/tigerlake/acp... PS2, Line 147: Arge3 Arg3