Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32336 )
Change subject: google/kukui: Get write protection status from WP GPIO
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32336/1/src/mainboard/google/kukui/chromeos....
File src/mainboard/google/kukui/chromeos.c:
https://review.coreboot.org/#/c/32336/1/src/mainboard/google/kukui/chromeos....
PS1, Line 36: !
Can we do 'gpio_get(GPIO_WP)' like daisy or gru?
gru:
fill_lb_gpios: get_write_protect_state() ^ !wp_polarity,
get_write_protect_state: gpio_get(GPIO_WP) ^ !wp_polarity;
daisy:
fill_lb_gpios: !get_write_protect_state()
get_write_protect_state: !gpio_get_value(GPIO_D16)
They are both doing exactly same thing (well, gru is slightly different because it has to deal with multiple config, but at least it's following same scheme).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32336
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I75b98b1d587abe5e8cdf3df28ea661bc1ffa19f9
Gerrit-Change-Number: 32336
Gerrit-PatchSet: 1
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-CC: Joel Kitching
kitching@google.com
Gerrit-CC: Tony Lin
tonycwlin@google.com
Gerrit-CC: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-CC: YH Lin
yueherngl@chromium.org
Gerrit-Comment-Date: Wed, 17 Apr 2019 07:19:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Daisuke Nojiri
dnojiri@chromium.org
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment