Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48328 )
Change subject: Revert "mb/clevo/cml-u: drop duplicated configuration of UART pads"
......................................................................
Patch Set 5:
same as for CB:48801 - not needed unless common uart gpio config got dropped
Eh what? You know that your linked change does something different than this one, right?
If we want to get rid of common GPIO code on soc/cannonlake, this change _is_ needed and necessary since it moves the pad configuration from SoC to mainboard. There is no way around it. This also applies to CB:48327.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48328
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6022935eaab748f82c6330be0729ff72f4880493
Gerrit-Change-Number: 48328
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 21 Dec 2020 21:32:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment