Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35164 )
Change subject: mediatek/mt8183: Use cached calibration result for faster bootup ......................................................................
Patch Set 23:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35164/12/src/soc/mediatek/mt8183/dr... File src/soc/mediatek/mt8183/dramc_init_setting.c:
https://review.coreboot.org/c/coreboot/+/35164/12/src/soc/mediatek/mt8183/dr... PS12, Line 616: dramc_dbg("bypass duty calibration\n");
no need add here
Ack
https://review.coreboot.org/c/coreboot/+/35164/12/src/soc/mediatek/mt8183/dr... PS12, Line 618: u8
why int better than u8?
I think using u8 is consistent with other code in this file.
https://review.coreboot.org/c/coreboot/+/35164/12/src/soc/mediatek/mt8183/dr... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/35164/12/src/soc/mediatek/mt8183/dr... PS12, Line 911: dramc_dbg("[bypass Gating]\n");
what is the meaning?
@huayang Why adding "[" and "]" in this debug message?
https://review.coreboot.org/c/coreboot/+/35164/12/src/soc/mediatek/mt8183/dr... PS12, Line 912: {
maybe move this to a standalone function so we don't need to have too many levels of indentation.
Done
https://review.coreboot.org/c/coreboot/+/35164/23/src/soc/mediatek/mt8183/dr... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/35164/23/src/soc/mediatek/mt8183/dr... PS23, Line 858: dramc_rx_dqs_gating_cal2 @huayang I have no idea how to name this function. Any suggestion?