Attention is currently required from: Keith Hui.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41459 )
Change subject: mb/asus/p2b: list all unused Super I/O resources
......................................................................
Patch Set 8:
(1 comment)
File src/mainboard/asus/p2b/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/41459/comment/f870c41d_f799e01e
PS8, Line 38: io 0x60 = 0
: io 0x62 = 0
We already have syntax to disable that resource: […]
Understood (actually I knew that already). The problem is not what this
code does, that's clear. It's that it is fragile (basically going a short
cut that exists only by coincidence). Currently the framework code allows
you to set two resources to the same value, but that could change. I just
wanted to get the warning out.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41459
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28e37c3a58f3a6b5a613733f26ac18d6a7b3be2e
Gerrit-Change-Number: 41459
Gerrit-PatchSet: 8
Gerrit-Owner: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Keith Hui
buurin@gmail.com
Gerrit-Comment-Date: Sun, 23 Jan 2022 23:31:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Keith Hui
buurin@gmail.com
Gerrit-MessageType: comment