Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35799 )
Change subject: soc/intel/sgx: convert SGX and PRMRR devicetree options to Kconfig
......................................................................
Patch Set 34:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35799/5/src/mainboard/intel/glkrvp/...
File src/mainboard/intel/glkrvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/35799/5/src/mainboard/intel/glkrvp/...
PS5, Line 89: config SOC_INTEL_COMMON_BLOCK_SGX_ENABLE
: bool
: default y
Sorry, I don't get what you mean. sgx was enabled in the devicetree (yes, mb specific) before. […]
good question... there is no benefit in doing so if the user does not use it explicitely; I'd be ok with disabling it per default instead
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35799
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f08e85898304bba6680075ca5d6bce26aef9a4d
Gerrit-Change-Number: 35799
Gerrit-PatchSet: 34
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 22 Oct 2019 19:04:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Michael Niewöhner
Gerrit-MessageType: comment