[coreboot-gerrit] [L] Change in coreboot[master]: mb/amd/birman/gpio: Configure birman GPIOs

[Fred Reitberger (Code Review)]

Attention is currently required from: Jason Glenesk, Felix Held.

Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69411 )

Change subject: mb/amd/birman/gpio: Configure birman GPIOs
......................................................................

Patch Set 5:

(2 comments)

File src/mainboard/amd/birman/gpio.c:

https://review.coreboot.org/c/coreboot/+/69411/comment/9c00322a_9b678672 
PS2, Line 31: 	PAD_SCI(GPIO_9, PULL_UP, EDGE_LOW),
> hm, i'd change this to GPI and maybe leave a comment that it's unclear if that needs to generate SCI […]

Done

File src/mainboard/amd/birman/gpio.c:

https://review.coreboot.org/c/coreboot/+/69411/comment/85c1181e_3ece6928 
PS4, Line 19: 	PAD_NF_SCI(GPIO_3, GPIOxx, PULL_NONE, EDGE_LOW),
> i'd use PAD_SCI(GPIO_3, PULL_NONE, EDGE_LOW) here; the PAD_NF_SCI macro is only needed when the gpio […]

Ack