Attention is currently required from: Jonathan Zhang, Patrick Rudolph.
Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51228 )
Change subject: soc/intel/xeon_sp: Set LPC EISS enable
......................................................................
Patch Set 3: Verified-1
(2 comments)
Patchset:
PS3:
Please also mention that VPD would not work any more as it operates in ring 0 only.
Also a good point. I don't think that we want to enable this.
PS3:
Probably don't want to do this based on the coreboot/flashrom/vpd usage model.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51228
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d768763618473a4c4d7a69fb3448691c5d07522
Gerrit-Change-Number: 51228
Gerrit-PatchSet: 3
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Patrick Rudolph
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 10 Mar 2021 23:41:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Patrick Rudolph
Gerrit-MessageType: comment