Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38920 )
Change subject: [WIP] mb/gigabyte: Add Gigabyte Z170X-Gaming 7 ......................................................................
Patch Set 13:
(18 comments)
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... File src/mainboard/gigabyte/ga-z170x-gaming7/Kconfig:
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... PS13, Line 5: select BOARD_ROMSIZE_KB_16384 : select HAVE_ACPI_RESUME : select HAVE_ACPI_TABLES : select HAVE_OPTION_TABLE : select HAVE_CMOS_DEFAULT : select INTEL_GMA_HAVE_VBT : select INTEL_INT15 : select SOC_INTEL_KABYLAKE : select SKYLAKE_SOC_PCH_H : select MAINBOARD_HAS_LIBGFXINIT : select SUPERIO_ITE_IT8728F # board has actually IT8628E : select MAINBOARD_USES_IFD_GBE_REGION Reorder alphabetically
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... File src/mainboard/gigabyte/ga-z170x-gaming7/acpi/dptf.asl:
PS13:
/* SPDX-License-Identifier: GPL-2.0-only */ […]
Done
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... PS13, Line 1: /* : * This file is part of the coreboot project. : * : * Copyright (C) 2014 Google Inc. : * Copyright (C) 2015 Intel Corporation. : * Copyright (C) 2019 Maxim Polyakov max.senia.poliak@gmail.com : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ Replace with .. /* SPDX-License-Identifier: GPL-2.0-only */
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... File src/mainboard/gigabyte/ga-z170x-gaming7/board_info.txt:
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... PS13, Line 2: Board URL: https://www.gigabyte.com/Motherboard/GA-Z170X-Gaming-7-rev-10 Add these .. Vendor name: Gigabyte Board name: GA Z170X Gaming 7 rev. 1.0
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... File src/mainboard/gigabyte/ga-z170x-gaming7/cmos.layout:
PS13:
## SPDX-License-Identifier: GPL-2.0-only […]
Done
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... PS13, Line 1: ## : ## This file is part of the coreboot project. : ## : ## Copyright (C) 2007-2008 coresystems GmbH : ## Copyright (C) 2016 Intel Corporation. : ## : ## This program is free software; you can redistribute it and/or modify : ## it under the terms of the GNU General Public License as published by : ## the Free Software Foundation; version 2 of the License. : ## : ## This program is distributed in the hope that it will be useful, : ## but WITHOUT ANY WARRANTY; without even the implied warranty of : ## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : ## GNU General Public License for more details. : ## Replace with .. GA-Z170X-Gaming-7-rev-10
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... File src/mainboard/gigabyte/ga-z170x-gaming7/devicetree.cb:
PS13:
## SPDX-License-Identifier: GPL-2.0-only […]
Done
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... PS13, Line 19: register "deep_s3_enable_ac" = "0" : register "deep_s3_enable_dc" = "0" : register "deep_s5_enable_ac" = "0" : register "deep_s5_enable_dc" = "0" Remove, because all 0
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... PS13, Line 267: device domain 0 on Add the following below this line .. subsystemid 0x1849 0x1912 inherit and replace every occurrence of .. subsystemid 0x1849 0x1912
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... File src/mainboard/gigabyte/ga-z170x-gaming7/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... PS13, Line 1: /* : * This file is part of the coreboot project. : * : * Copyright (C) 2007-2009 coresystems GmbH : * Copyright (C) 2015 Google Inc. : * Copyright (C) 2016 Intel Corporation : * Copyright (C) 2019 Maxim Polyakov max.senia.poliak@gmail.com : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ Replace with .. /* SPDX-License-Identifier: GPL-2.0-only */
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... PS13, Line 23: 0x02 Replace 0x02 by ACPI_DSDT_REV_2
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... PS13, Line 23: // DSDT revision: ACPI v2.0 and up Remove
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... File src/mainboard/gigabyte/ga-z170x-gaming7/gpio.c:
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... PS13, Line 1: /* : * This file is part of the coreboot project. : * : * This program is free software; you can redistribute it and/or : * modify it under the terms of the GNU General Public License as : * published by the Free Software Foundation; version 2 of : * the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ Replace with .. /* SPDX-License-Identifier: GPL-2.0-only */
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... PS13, Line 15: #ifndef CFG_GPIO_H : #define CFG_GPIO_H No guards necessary here
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... PS13, Line 265: #endif /* CFG_GPIO_H */ Remove
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... File src/mainboard/gigabyte/ga-z170x-gaming7/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... PS13, Line 1: /* : * This file is part of the coreboot project. : * : * Copyright (C) 2019 Christoph Pomaska : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the : * GNU General Public License for more details. : */ Replace with .. /* SPDX-License-Identifier: GPL-2.0-only */
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... File src/mainboard/gigabyte/ga-z170x-gaming7/ramstage.c:
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... PS13, Line 1: /* : * This file is part of the coreboot project. : * : * Copyright (C) 2016 Intel Corporation : * Copyright (C) 2019 Maxim Polyakov max.senia.poliak@gmail.com : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ Replace with .. /* SPDX-License-Identifier: GPL-2.0-only */
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... File src/mainboard/gigabyte/ga-z170x-gaming7/romstage.c:
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... PS13, Line 1: /* : * This file is part of the coreboot project. : * : * Copyright (C) 2016 Intel Corporation. : * Copyright (C) 2019 Maxim Polyakov max.senia.poliak@gmail.com : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ Replace with .. /* SPDX-License-Identifier: GPL-2.0-only */