Attention is currently required from: Jarried Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86041?usp=email )
Change subject: soc/mediatek/mt8196: Add dvfs driver ......................................................................
Patch Set 2:
(9 comments)
This change is ready for review.
Commit Message:
https://review.coreboot.org/c/coreboot/+/86041/comment/23d620e9_a0acd280?usp... : PS2, Line 7: dvfs DVFS
https://review.coreboot.org/c/coreboot/+/86041/comment/2c2db27e_5d8eb354?usp... : PS2, Line 8: Please elaborate.
File src/soc/mediatek/mt8196/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/86041/comment/03ed6bfa_c8b7529d?usp... : PS2, Line 43: romstage-y += mtk_dvfs.c Rename and sort this.
https://review.coreboot.org/c/coreboot/+/86041/comment/8e21d48f_9c645b4e?usp... : PS2, Line 45: mtk_pwrsel Note that I also renamed this in CB:86059.
File src/soc/mediatek/mt8196/include/soc/mtk_dvfs.h:
PS2: Rename to dvfs.h
https://review.coreboot.org/c/coreboot/+/86041/comment/4c661fb3_a146b934?usp... : PS2, Line 3: MTK_DVFS DVFS
https://review.coreboot.org/c/coreboot/+/86041/comment/27083946_972db8d6?usp... : PS2, Line 9: C What does "C" mean here?
File src/soc/mediatek/mt8196/mtk_dvfs.c:
PS2: Rename dvfs.c
https://review.coreboot.org/c/coreboot/+/86041/comment/a6ca7522_4c6d37e4?usp... : PS2, Line 11: 0x01 `BIT(0)`