Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32026 )
Change subject: soc/intel/cannonlake: FSP UPD update ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32026/1/src/soc/intel/cannonlake/chip.h File src/soc/intel/cannonlake/chip.h:
https://review.coreboot.org/#/c/32026/1/src/soc/intel/cannonlake/chip.h@142 PS1, Line 142: uint8_t SlpS0WithGbeSupport; : uint8_t PchPmSlpS0VmRuntimeControl; : uint8_t PchPmSlpS0Vm070VSupport; : uint8_t PchPmSlpS0Vm075VSupport; Can you please add comments indicating what each param does?