Attention is currently required from: Star Labs.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52796 )
Change subject: src/intel: Add LOCKDIS to mark SPI as writable in SKL
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Please go more I to detail here. By default coreboot does not write protect anything in the SPI flash and there's no SMM handler to protect the flash. If fwupd can't detect that it might needs to be fixed, not coreboot.
Not locking anything might be useful for debugging, but it should not made it into a devicetree setting used by default.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52796
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I712972428dd22373d8655ce72d36c0957ee9a900
Gerrit-Change-Number: 52796
Gerrit-PatchSet: 4
Gerrit-Owner: Star Labs
admin@starlabs.systems
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Star Labs
admin@starlabs.systems
Gerrit-Comment-Date: Fri, 07 May 2021 05:24:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment