Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46487 )
Change subject: mb/google/volteer/var/terrador: Update DPTF parameters ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46487/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/terrador/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46487/4/src/mainboard/google/voltee... PS4, Line 24: [0] = DPTF_PASSIVE(CPU, CPU, 85, 1000), : [1] = DPTF_PASSIVE(CPU, TEMP_SENSOR_1, 65, 6000), : [2] = DPTF_PASSIVE(CHARGER, TEMP_SENSOR_0, 65, 6000), : [3] = DPTF_PASSIVE(CPU, TEMP_SENSOR_2, 65, 6000), : [4] = DPTF_PASSIVE(CPU, TEMP_SENSOR_3, 65, 6000)}" : nit: it's a little easier to read if all of the columns are lined up with tabs
https://review.coreboot.org/c/coreboot/+/46487/4/src/mainboard/google/voltee... PS4, Line 62: # DPTF 0x9A03 nit: with the alias names (`ref dptf`, I don't think these comments are as helpful)
https://review.coreboot.org/c/coreboot/+/46487/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/todor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46487/4/src/mainboard/google/voltee... PS4, Line 24: [0] = DPTF_PASSIVE(CPU, CPU, 85, 1000), : [1] = DPTF_PASSIVE(CPU, TEMP_SENSOR_1, 65, 6000), : [2] = DPTF_PASSIVE(CHARGER, TEMP_SENSOR_0, 65, 6000), : [3] = DPTF_PASSIVE(CPU, TEMP_SENSOR_2, 65, 6000), : [4] = DPTF_PASSIVE(CPU, TEMP_SENSOR_3, 65, 6000)}" nit: it's a little easier to read if all of the columns are lined up with tabs
https://review.coreboot.org/c/coreboot/+/46487/4/src/mainboard/google/voltee... PS4, Line 62: # DPTF 0x9A03 nit: same