build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48532 )
Change subject: soc/amd/picasso: Add cb support to publish CRAT ACPI object ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/c/coreboot/+/48532/1/src/include/acpi/acpi_crat.... File src/include/acpi/acpi_crat.h:
https://review.coreboot.org/c/coreboot/+/48532/1/src/include/acpi/acpi_crat.... PS1, Line 20: #define CRAT_HSA_PR_FLAG_CPU_PRES_SHFT 2 'PRES' may be misspelled - perhaps 'PRESS'?
https://review.coreboot.org/c/coreboot/+/48532/1/src/include/acpi/acpi_crat.... PS1, Line 21: #define CRAT_HSA_PR_FLAG_CPU_PRES (0x1 << CRAT_HSA_PR_FLAG_CPU_PRES_SHFT) 'PRES' may be misspelled - perhaps 'PRESS'?
https://review.coreboot.org/c/coreboot/+/48532/1/src/include/acpi/acpi_crat.... PS1, Line 21: #define CRAT_HSA_PR_FLAG_CPU_PRES (0x1 << CRAT_HSA_PR_FLAG_CPU_PRES_SHFT) 'PRES' may be misspelled - perhaps 'PRESS'?
https://review.coreboot.org/c/coreboot/+/48532/1/src/include/acpi/acpi_crat.... PS1, Line 22: #define CRAT_HSA_PR_FLAG_GPU_PRES_SHFT 3 'PRES' may be misspelled - perhaps 'PRESS'?
https://review.coreboot.org/c/coreboot/+/48532/1/src/include/acpi/acpi_crat.... PS1, Line 23: #define CRAT_HSA_PR_FLAG_GPU_PRES (0x1 << CRAT_HSA_PR_FLAG_GPU_PRES_SHFT) 'PRES' may be misspelled - perhaps 'PRESS'?
https://review.coreboot.org/c/coreboot/+/48532/1/src/include/acpi/acpi_crat.... PS1, Line 23: #define CRAT_HSA_PR_FLAG_GPU_PRES (0x1 << CRAT_HSA_PR_FLAG_GPU_PRES_SHFT) 'PRES' may be misspelled - perhaps 'PRESS'?