HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32407 )
Change subject: soc/amd/picasso: Create picasso as a copy of stoneyridge
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32407/1/src/soc/amd/picasso/acpi.c
File src/soc/amd/picasso/acpi.c:
https://review.coreboot.org/#/c/32407/1/src/soc/amd/picasso/acpi.c@72
PS1, Line 72: void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt)
sorry, maybe my question is out of topic.
but this function is defined in included <arch/acpi.h>
and we can find also the same function name here: src/arch/x86/acpi.c .
so the compiler will use current function or the one from "src/arch/x86/acpi.c"?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32407
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6809bd1eea304f76dd9000c079b3ed09f94dbd3b
Gerrit-Change-Number: 32407
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Fri, 26 Apr 2019 15:54:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment