[coreboot-gerrit] Change in ...coreboot[master]: AGESA/binaryPI: Add NULL pointers check

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31026 )

Change subject: AGESA/binaryPI: Add NULL pointers check
......................................................................

Patch Set 2:

(1 comment)

I spent a little time looking at build//static.c for apu2 vs. a stoneyridge board.  It's not immediately clear to me why apu2 isn't working but grunt is OK.

https://review.coreboot.org/#/c/31026/2/src/northbridge/amd/agesa/family16kb... 
File src/northbridge/amd/agesa/family16kb/northbridge.c:

https://review.coreboot.org/#/c/31026/2/src/northbridge/amd/agesa/family16kb... 
PS2, Line 576: 	dev = pcidev_on_root(1, 1);
For each file, maybe reverse the check to print an error and get out?

if (!dev) {
    printk(BIOS_ERR, "Can't find device 1.1 to disable NoSnoop\n");
    return;
  }