Attention is currently required from: Sean Rhodes, Jason Nien, Patrick Rudolph, Caveh Jalali, Christian Walter, Martin Roth, Boris Mittelberg.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74452 )
Change subject: SMBIOS: Move identification strings
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74452/comment/d0f28a6c_e6e213c9
PS3, Line 9: This improve ccache hit rate
is there a better argument to be made for moving […]
The motivation was to split these strings away from build/config.h to build/board_id.h, which will only be an input for lib/identity.c. I am still experimenting with ccache to see if I am able to transform hits from "preprocessor hit" to "direct hit", latter is typically much faster and may result with smaller memory footprint.
I have not inspected the binaries that closely yet to check if constant Kconfig strings currently appear twice expanded in the binaries. Output of "objdump -r -d" may actually appear nicer since the references are to symbolic names found in source.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74452
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28a8199b4a5482984dd7fdde67e90acca5af5ca6
Gerrit-Change-Number: 74452
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Tue, 18 Apr 2023 07:54:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Gerrit-MessageType: comment