Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41384 )
Change subject: device/pci_device: Add notion of "hidden" PCI devices ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41384/7/src/device/pci_device.c File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/41384/7/src/device/pci_device.c@795 PS7, Line 795: hidden_pci_dev_ops
That would also imply pci_bus_ops_pci on line 773 isn't necessary either. […]
Yeah... I'll remove that in a later patch.
https://review.coreboot.org/c/coreboot/+/41384/7/src/device/pci_device.c@122... PS7, Line 1223: * ID as if there were no device there (0xffffffff).
Understood. But it seems a bit too limited. Would it suffice to say that […]
Sure, SGTM. For the PMC case, I believe the FSP uses the config space during FSP-S, and then disables it so no one else can touch it. I'm not sure why it's still even a PCI device, except that it has previously been?