Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36552 )
Change subject: soc/intel/tigerlake/romstage: Do initial SoC commit till romstage ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36552/4/src/soc/intel/tigerlake/inc... File src/soc/intel/tigerlake/include/soc/romstage.h:
https://review.coreboot.org/c/coreboot/+/36552/4/src/soc/intel/tigerlake/inc... PS4, Line 26: enum board_type {
Most values aren't even used on Icelake.
Please refer to https://github.com/coreboot/coreboot/blob/08aeda6c14886d39e04382c7fe6d24c4b4...
https://github.com/coreboot/coreboot/blob/08aeda6c14886d39e04382c7fe6d24c4b4...