3 Jun
2021
3 Jun
'21
4:39 p.m.
Attention is currently required from: Nico Huber, Paul Menzel, Arthur Heymans, Alexander Couzens, Patrick Rudolph, Swift Geek (Sebastian Grzywna). Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55169 )
Change subject: mb/lenovo/t410: Enable WWAN and WUSB PCIe ports ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Change looks fine but from schematics I think comment should be swapped around - port #1 being WWAN […]
Looks like the comments show the mapping on preproduction boards [old], and production boards use a different mapping [new].
[old]: https://i.imgur.com/eb0CqN9.png [new]: https://i.imgur.com/whvBKmr.png
--
To view, visit https://review.coreboot.org/c/coreboot/+/55169
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I26ace6e043c7c66f8944f0986923014703423b8c
Gerrit-Change-Number: 55169
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Swift Geek (Sebastian Grzywna) swiftgeek@gmail.com
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Alexander Couzens lynxis@fe80.eu
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Attention: Swift Geek (Sebastian Grzywna) swiftgeek@gmail.com
Gerrit-Comment-Date: Thu, 03 Jun 2021 16:39:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Swift Geek (Sebastian Grzywna) swiftgeek@gmail.com
Gerrit-MessageType: comment