Matt Delco has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44939 )
Change subject: mb/google/dedede/var/drawcia: Add MIPI camera support ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44939/8/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/drawcia/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44939/8/src/mainboard/google/dedede... PS8, Line 214: 0x0C I've seen other boards use 2 or 3 for dw9714, but I'm not sure which (if any) of the 3 values is correct. I mostly hope that the 0x0C isn't being confused with lines that could be added that indicate the I2C address of the VCM and NVM devices:
register "vcm_address" = "0x0C" register "rom_address" = "0x50"
The second line isn't so useful unless/until "ssdb.rom_type" is specified, but I'm even less sure about what value to use for the GT24C08 model of NVM.
https://review.coreboot.org/c/coreboot/+/44939/8/src/mainboard/google/dedede... PS8, Line 248: register "acpi_hid" = "ACPI_DT_NAMESPACE_HID" NIT: ACPI_DT_NAMESPACE_HID is already the default for INTEL_ACPI_CAMERA_VCM so this line isn't needed (but not harmful either).