Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33806 )
Change subject: device/oprom: Update vbe_info_t as per vbe specification 3.0 ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33806/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33806/2//COMMIT_MSG@13 PS2, Line 13: http://www.vesa.org/public/VBE/vbe3.pdf
The whole code is written such that `vbe_info_t` isn't (and doesn't […]
vbe_info_t structure has existing bug, Please refer to comment from Arthur as well.
https://review.coreboot.org/c/coreboot/+/33782/1/src/include/vbe.h#48
this structure was not compliant to vbe spec. By approach here to make it proper.
I can achieve my purpose without changing this code but then i will keep existing bug open where current vbe_info_t structure can't provide correct total_memory value.
https://review.coreboot.org/c/coreboot/+/33806/2/src/device/oprom/yabel/vbe.... File src/device/oprom/yabel/vbe.c:
https://review.coreboot.org/c/coreboot/+/33806/2/src/device/oprom/yabel/vbe.... PS2, Line 143:
I see you are deferring this conversion to vbe_get_info() below. But why? […]
This logic developed based on wrong vbe_info_t structure which is not complaint to spec