[coreboot-gerrit] [S] Change in coreboot[master]: vga: Change the arguments of vga_write_text to support extended ASCII

[Tarun Tuli (Code Review)]

Attention is currently required from: Hsuan Ting Chen, Nico Huber, Subrata Banik, Hsuan-ting Chen.

Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73099 )

Change subject: vga: Change the arguments of vga_write_text to support extended ASCII
......................................................................

Patch Set 3:

(1 comment)

File src/include/pc80/vga.h:

https://review.coreboot.org/c/coreboot/+/73099/comment/960f4184_e0057dc2 
PS1, Line 36: void vga_write_text(enum VGA_TEXT_ALIGNMENT alignment, unsigned int line, const char *string);
> I was hesitate to change the arguments is because this will reject using string literal as: […]

Ahh yes - makes sense.

I'd personally prefer the cast rather than a different function.