Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak. Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52859 )
Change subject: mb/google/brya: enable DPTF functionality for brya ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52859/comment/1b5ad243_aa08dadc PS1, Line 7: enable DPTF functionality for brya
Duplicate of CB:52691?
This CL has generic/common changes for baseboard.
File src/mainboard/google/brya/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/52859/comment/afba573e_2ea019cb PS1, Line 123: chip drivers/intel/dptf
Shouldn't these changes go into overridetree?
As per our understanding, these changes are required as under baseboard changes for brya variants and these are generic/common changes which will be default under /brya/variants/"baseboard"/ in devicetree file. On top of these ODM/OEM can change/over write above (baseboard/devicetree.cb) changes for their design specific changes under /brya/variants/"Design1" in overridetree.cb file. Also, another different ODM/OEM can add their design specific changes under /brya/variants/"Design2" in overridetree.cb file.