[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Add GPID and CGPM methods to GPIO ASL

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34179 )

Change subject: soc/intel/cannonlake: Add GPID and CGPM methods to GPIO ASL
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34179/6/src/soc/intel/cannonlake/ac... 
File src/soc/intel/cannonlake/acpi/gpio.asl:

https://review.coreboot.org/c/coreboot/+/34179/6/src/soc/intel/cannonlake/ac... 
PS6, Line 134: Store (PID_GPIOCOM0, Local0)
> Humm.. I was thinking about the same when reviewing this. […]

i would recommend for a check above itself and return
If (LAnd (LGreaterEqual (Arg0, 1), LLessEqual (Arg0, 4))