[coreboot-gerrit] Change in coreboot[master]: hatch: automate creating a new variant in coreboot

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35239 )

Change subject: hatch: automate creating a new variant in coreboot
......................................................................

Patch Set 14:

(2 comments)

https://review.coreboot.org/c/coreboot/+/35239/13/util/mainboard/google/hatc... 
File util/mainboard/google/hatch/create_coreboot_variant.sh:

https://review.coreboot.org/c/coreboot/+/35239/13/util/mainboard/google/hatc... 
PS13, Line 54: # Start a branch. Use YMD timestamp to avoid collisions.
             : DATE=$(date +%Y%m%d)
             : repo start "create_${variant}_${DATE}"
Get rid of this?  This is just a personal preference, right? 
If you want to keep it, start the branch with git instead of repo?

https://review.coreboot.org/c/coreboot/+/35239/13/util/mainboard/google/hatc... 
File util/mainboard/google/hatch/dptf.asl.tmpl:

https://review.coreboot.org/c/coreboot/+/35239/13/util/mainboard/google/hatc... 
PS13, Line 4:  * Copyright __YEAR__ Google LLC
> This file actually shouldn't be part of the CL; I deleted it but it didn't get cherry-picked. […]

Yes, I think so.