Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32708 )
Change subject: mb/gigabyte/ga-b75m-d3{h,v}: Switch to variant setup
......................................................................
Patch Set 13: Code-Review+1
(1 comment)
The data.vbt files are the same, maybe they don't need to be duplicated?
https://review.coreboot.org/#/c/32708/13/src/mainboard/gigabyte/ga-b75m-d3h/...
File src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75m-d3v/romstage.c:
https://review.coreboot.org/#/c/32708/13/src/mainboard/gigabyte/ga-b75m-d3h/...
PS13, Line 91: /* FIXME: This board only has two DIMM slots! */
This is the only line that differs between both romstage.c files, the rest are the same.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32708
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia175207a2568aefe1aa9bd8d4d990de6a26f1657
Gerrit-Change-Number: 32708
Gerrit-PatchSet: 13
Gerrit-Owner: Alex James
theracermaster@gmail.com
Gerrit-Reviewer: Alex James
theracermaster@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 23 May 2019 15:19:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment