Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35110 )
Change subject: mb/google/kukui: Load calibration params and run DRAM calibration flow ......................................................................
Patch Set 49:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35110/39/src/mainboard/google/kukui... File src/mainboard/google/kukui/romstage.c:
https://review.coreboot.org/c/coreboot/+/35110/39/src/mainboard/google/kukui... PS39, Line 100: if (!read_calibration_data_from_flash(&dparam, sizeof(dparam)) || : !is_valid_dramc_param(&dparam) || : dparam.header.config != config) {
How about using 'BIOS_NOTICE'? I don't think missing flash data is an error.
Done
https://review.coreboot.org/c/coreboot/+/35110/47/src/mainboard/google/kukui... File src/mainboard/google/kukui/romstage.c:
https://review.coreboot.org/c/coreboot/+/35110/47/src/mainboard/google/kukui... PS47, Line 36: BIOS_INFO
BIOS_DEBUG
Done
https://review.coreboot.org/c/coreboot/+/35110/47/src/mainboard/google/kukui... PS47, Line 55: .write_to_flash = &write_calibration_data_to_flash,
sounds like a good idea. […]
Done