Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44703 )
Change subject: soc/mediatek/mt8192: Do EMI init before dram calibration
......................................................................
Patch Set 55: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/44703/52//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44703/52//COMMIT_MSG@9
PS52, Line 9: Reference datasheet: External Memory Interface (EMI).pdf
Add "Document No: RH-A-2020-0055" to prevent the datasheet from renaming.
Ack
https://review.coreboot.org/c/coreboot/+/44703/46/src/soc/mediatek/mt8192/em...
File src/soc/mediatek/mt8192/emi.c:
https://review.coreboot.org/c/coreboot/+/44703/46/src/soc/mediatek/mt8192/em...
PS46, Line 13: write32
The datasheet is: External Memory Interface (EMI).pdf, please help to review, thanks.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44703
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b778698a09c999252fef3153ac1e869ea9d90cd
Gerrit-Change-Number: 44703
Gerrit-PatchSet: 55
Gerrit-Owner: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Duan huayang
huayang.duan@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 21 Dec 2020 03:03:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Xi Chen
xixi.chen@mediatek.com
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Yidi Lin
yidi.lin@mediatek.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment