Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45780 )
Change subject: amdfwtool: Remove the assumption of ROM_SIZE
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45780/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45780/1//COMMIT_MSG@9
PS1, Line 9: Every platform passes (and need to) the --flashsize to the command parameter,
: So we remove the macro definition.
please add that that define that gets removed here was about a built-time rom size option and reflow […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45780
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I894e833ed23a7da38b36986b624e7dcdf1f4090c
Gerrit-Change-Number: 45780
Gerrit-PatchSet: 6
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 01 Oct 2020 10:18:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment