Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46514 )
Change subject: mrc_cache: Add tpm_hash_index field to cache_region struct ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
LGTM after the condition for HAS_RECOVERY_MRC_CACHE is dropped for tpm_hash_index.
https://review.coreboot.org/c/coreboot/+/46514/3/src/drivers/mrc_cache/mrc_c... File src/drivers/mrc_cache/mrc_cache.c:
https://review.coreboot.org/c/coreboot/+/46514/3/src/drivers/mrc_cache/mrc_c... PS3, Line 58: HAS_RECOVERY_MRC_CACHE Sorry about the confusion. I had a stale comment on earlier patchset which I missed removing before posting the latest comments on patchset 2. As Julius mentioned, this is not really required.