21 Feb
2021
21 Feb
'21
9:14 p.m.
Attention is currently required from: Martin Roth, Furquan Shaikh, Angel Pons, Subrata Banik, Michael Niewöhner, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50938 )
Change subject: soc/intel: Factor out acpigen GPIO helpers ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/soc/intel/skylake/Kconfig:
https://review.coreboot.org/c/coreboot/+/50938/comment/221177bd_f46f0335 PS2, Line 51: BLOCK_ACPI
just for the record: actually, ACPI isn't an IP block. […]
Who put lpit.c in this very same directory? 😉
--
To view, visit https://review.coreboot.org/c/coreboot/+/50938
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27f198d403f6ba05ba72ae0652da224d4cbf323a
Gerrit-Change-Number: 50938
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Subrata Banik subrata.banik@intel.com
Gerrit-Attention: Michael Niewöhner foss@mniewoehner.de
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Sun, 21 Feb 2021 21:14:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Michael Niewöhner foss@mniewoehner.de
Gerrit-MessageType: comment