Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46555 )
Change subject: soc/intel/xeon_sp/cpx: Add txt_get_chipset_dpr callback ......................................................................
Patch Set 5: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/46555/5/src/soc/intel/xeon_sp/cpx/c... File src/soc/intel/xeon_sp/cpx/chip.c:
https://review.coreboot.org/c/coreboot/+/46555/5/src/soc/intel/xeon_sp/cpx/c... PS5, Line 571: die Can something else be done instead of dying?
https://review.coreboot.org/c/coreboot/+/46555/5/src/soc/intel/xeon_sp/cpx/c... PS5, Line 571: DEV I'd use `dev` in lowercase (or `device`), and also indicate which stack this is on.
https://review.coreboot.org/c/coreboot/+/46555/5/src/soc/intel/xeon_sp/cpx/c... PS5, Line 581: die("Unable to find VTD PCI DEV"); Same comments here
https://review.coreboot.org/c/coreboot/+/46555/5/src/soc/intel/xeon_sp/cpx/c... PS5, Line 584: memcmp(&dpr, &test_dpr, sizeof(dpr)) dpr.raw != test_dpr.raw