29 Jan
2019
29 Jan
'19
9:17 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31125 )
Change subject: siemens/mc_apl2: Activate TPM support ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31125/2/src/mainboard/siemens/mc_apl1/varian... File src/mainboard/siemens/mc_apl1/variants/mc_apl2/gpio.c:
https://review.coreboot.org/#/c/31125/2/src/mainboard/siemens/mc_apl1/varian... PS2, Line 366: /* SIO_SPI_FS1_1V8 - Connected to ESPI_CS1# of SMARC connector. */ Doesn't the comment need an update?
Also, this makes one question the other comments. What's SMARC btw? ;)
--
To view, visit https://review.coreboot.org/c/coreboot/+/31125
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b0d5a6f2c230187857c2428a70de61f21da6724
Gerrit-Change-Number: 31125
Gerrit-PatchSet: 2
Gerrit-Owner: Mario Scheithauer mario.scheithauer@siemens.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Mario Scheithauer mario.scheithauer@siemens.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Tue, 29 Jan 2019 20:17:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment