28 Nov
2023
28 Nov
'23
11:28 p.m.
Attention is currently required from: Arthur Heymans, Martin L Roth, Paul Menzel.
Srinivas Hegde has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79218?usp=email )
Change subject: arch/x86/Makefile.inc: Do not pass CPPFLAGS to linker ......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79218/comment/e5b60f58_cb7e46f8 : PS4, Line 10: ramstage. This is superflous as these are only meant to be compiler flags and should not be passed to the linker.
Please wrap at 72 characters max.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/79218?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia3cd51be6be252aa796191cf0d2cd91d393c8878
Gerrit-Change-Number: 79218
Gerrit-PatchSet: 5
Gerrit-Owner: Srinivas Hegde srinivashegde@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Reviewer: Patrick Georgi patrick@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Martin L Roth gaumless@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 28 Nov 2023 22:28:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth gaumless@gmail.com
Gerrit-MessageType: comment