Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34711 )
Change subject: google/mistral: LED Pattern change ......................................................................
Patch Set 8:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34711/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34711/8//COMMIT_MSG@7 PS8, Line 7: google/mistral: LED Pattern change Please use statements for the commit message summary: Change LED pattern
https://review.coreboot.org/c/coreboot/+/34711/8//COMMIT_MSG@15 PS8, Line 15: brank break?
https://review.coreboot.org/c/coreboot/+/34711/8//COMMIT_MSG@16 PS8, Line 16: 8seconds Space before seconds.
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... File src/drivers/i2c/lp5562/led_lp5562_programs.c:
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 60: 11 21 C000 end Please split out format changes from functional changes.