[coreboot-gerrit] [S] Change in coreboot[master]: Revert "mb/starlabs/*: Remove sleepstates.asl"

[Benjamin Doron (Code Review)]

Attention is currently required from: Sean Rhodes, Maximilian Brune, Angel Pons.

Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73894 )

Change subject: Revert "mb/starlabs/*: Remove sleepstates.asl"
......................................................................

Patch Set 2:

(1 comment)

Patchset:

PS2:
> We could have coreboot set those to something big by default, better working that not. […]

Well, they shouldn't be *too* big. I've sent patches to the EDK2 mailing list, and you're CC'ed as a maintainer, Sean. I've tested that it's now correct according to BDS, but I haven't tested S4. One of ACPI reclaim or ACPI NVs also needed a slight increase.

I don't entirely know the context this "above/below 4G" was added, but "below 4G" was the default behaviour before UefiPayload dropped PEI phase. It seems the HOB generation was lost then. But this behaviour only seems to be an artifact of how EDK2 uses the heap, while it's intended for keeping the memory map defragmented. And the DXE core uses it to find a good memory range of sufficient size.

Qubes needed below 4G? I think this happens to be the correct behaviour in all cases. I also think that fixes the memory map from EDK2's perspective, hopefully.