Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/19535 )
Change subject: drivers/pc80/tpm: Fix missing tis_close() function and TPM deactivation.
......................................................................
Patch Set 2: Code-Review-1
(2 comments)
https://review.coreboot.org/#/c/19535/2/src/drivers/pc80/tpm/romstage.c
File src/drivers/pc80/tpm/romstage.c:
Line 192: tis_close();
you can't close it, you haven't opened it yet.
Line 197: tis_close();
you can't close it, you haven't opened it yet.
--
To view, visit
https://review.coreboot.org/19535
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a06f6a29015708e4bc1de6e6678827c28b84e98
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Tobias Diedrich
ranma+coreboot@tdiedrich.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-HasComments: Yes