Attention is currently required from: Saurabh Mishra, Kangheui Won, Rizwan Qureshi.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63707 )
Change subject: vendorcode/intel/fsp: Update FSP header file for Alder Lake N FSP v3133.00
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63707/comment/69420a43_6060add3
PS1, Line 9: The headers added are generated as per FSP v3133.00
: Previous FSP version was v3054.02
: Changes Include:
Sure, resolved with dot in end of sentences.
No, please fully read my comment. Please format it like:
```
vc/intel/fsp: alderlake_n: Update FSP header file from v3054.02 to v3133.00
The headers added are generated as per FSP v3133.00. Previous FSP
version was v3054.02.
Changes include:
- UPD Enable eMMC Controller Offset removed in FspsUpd.h
- UPD UnusedUpdSpace name update in FspmUpd.h
```
Patchset:
PS3:
As author, you do not need to score your own change-sets.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63707
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b921e2aa467597a1c764fc554e2e83e5bb542e8
Gerrit-Change-Number: 63707
Gerrit-PatchSet: 3
Gerrit-Owner: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Reka Norman
rekanorman@chromium.org
Gerrit-CC: Saurabh Mishra
mishra.saurabh@intel.corp-partner.google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Saurabh Mishra
mishra.saurabh@intel.corp-partner.google.com
Gerrit-Comment-Date: Tue, 19 Apr 2022 18:12:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Saurabh Mishra
mishra.saurabh@intel.corp-partner.google.com
Gerrit-MessageType: comment