Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86467?usp=email )
Change subject: mb/google/glados/var/cave: Set SYSTEM_TYPE_CONVERTIBLE ......................................................................
mb/google/glados/var/cave: Set SYSTEM_TYPE_CONVERTIBLE
Cave is a 2-in-1 device, this sets the SMBIOS enclosure type properly.
Change-Id: I8f2ec82c97676aa315c18286b5e2eb94d46004ec Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/86467 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Singer service+coreboot-gerrit@felixsinger.de Reviewed-by: Andy Ebrahiem ahmet.ebrahiem@9elements.com --- M src/mainboard/google/glados/Kconfig 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: Felix Singer: Looks good to me, approved build bot (Jenkins): Verified Andy Ebrahiem: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/glados/Kconfig b/src/mainboard/google/glados/Kconfig index 57d54d0..287d9383 100644 --- a/src/mainboard/google/glados/Kconfig +++ b/src/mainboard/google/glados/Kconfig @@ -20,7 +20,7 @@ select MEMORY_MAPPED_TPM select MAINBOARD_HAS_TPM1 select SOC_INTEL_SKYLAKE - select SYSTEM_TYPE_LAPTOP + select SYSTEM_TYPE_LAPTOP if !SYSTEM_TYPE_CONVERTIBLE
config BOARD_GOOGLE_ASUKA select BOARD_GOOGLE_BASEBOARD_GLADOS @@ -43,6 +43,7 @@ select INTEL_GMA_HAVE_VBT select MAINBOARD_NO_FSP_GOP select NHLT_MAX98357 if INCLUDE_NHLT_BLOBS + select SYSTEM_TYPE_CONVERTIBLE
config BOARD_GOOGLE_CHELL select BOARD_GOOGLE_BASEBOARD_GLADOS