Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46977 )
Change subject: sb/intel/lynxpoint: Use common code to generate HPET table
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46977/1/src/southbridge/intel/lynxp...
File src/southbridge/intel/lynxpoint/lpc.c:
https://review.coreboot.org/c/coreboot/+/46977/1/src/southbridge/intel/lynxp...
PS1, Line 758:
: printk(BIOS_DEBUG, "ACPI: * HPET\n");
:
: hpet = (acpi_hpet_t *)current;
: current += sizeof(acpi_hpet_t);
: current = acpi_align_current(current);
: acpi_create_hpet(hpet);
: acpi_add_table(rsdp, hpet);
Good point
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46977
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6b90c9a7a00af0322c6dd15d2c4ecf2c513d0cc
Gerrit-Change-Number: 46977
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 29 Oct 2020 22:02:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment