build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47493 )
Change subject: nb/intel/sandybridge: Extract some IOSAV sequences into macros ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47493/5/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_common.h:
https://review.coreboot.org/c/coreboot/+/47493/5/src/northbridge/intel/sandy... PS5, Line 152: #define READ_MPR_SEQUENCE(t_mod, loops, gap, loops2, post2) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/47493/5/src/northbridge/intel/sandy... PS5, Line 159: */ \ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/47493/5/src/northbridge/intel/sandy... PS5, Line 220: */ \ Avoid unnecessary line continuations