Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38016 )
Change subject: Documentation/superio: add generic PNP device documentation ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38016/4/Documentation/superio/commo... File Documentation/superio/common/pnp.md:
https://review.coreboot.org/c/coreboot/+/38016/4/Documentation/superio/commo... PS4, Line 5: PNP devices are usually connected to the LPC bus of a system and shouldn't be confused with PCI(e) devices that use a completely different plug and play mechanism.
According to https://doc.coreboot.org/getting_started/writing_documentation. […]
Done.
I asked in the leadership meeting what the rationale for the 72 chars per line vs. the 96 for code was; for code it's more, since the code usually has 2 levels of indentation on average, but the documentation not.
https://review.coreboot.org/c/coreboot/+/38016/5/Documentation/superio/commo... File Documentation/superio/common/pnp.md:
https://review.coreboot.org/c/coreboot/+/38016/5/Documentation/superio/commo... PS5, Line 5: LPC
or eSPI
Done
https://review.coreboot.org/c/coreboot/+/38016/5/Documentation/superio/commo... PS5, Line 21: super
Super, same below
Done
https://review.coreboot.org/c/coreboot/+/38016/5/Documentation/superio/commo... PS5, Line 28: allLDNs
space
Done