Attention is currently required from: Raul Rangel, Kyösti Mälkki, Karthik Ramasubramanian.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58945 )
Change subject: google/guybrush: Move SPI speed override
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
moving the spi speed override out of chromeos.c sounds good to me. i'd do the removal of the $(CONFIG_CHROMEOS) guard in a separate patch, since that's not directly related to moving out the spi speed override. if you want to keep it as one patch, please mention the additional change in the commit message though. Maybe Raul and Karthik have an opinion on this
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58945
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3db89f252af1f44e9539497c05bdf965565a191
Gerrit-Change-Number: 58945
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 04 Nov 2021 15:02:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment