Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34616 )
Change subject: soc/intel/cnl: Only print ME status one time
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34616/1/src/soc/intel/cannonlake/me...
File src/soc/intel/cannonlake/me.c:
https://review.coreboot.org/c/coreboot/+/34616/1/src/soc/intel/cannonlake/me...
PS1, Line 302:
I believe this was there to ensure that ME status gets printed on S3 resume. […]
It gets printed at boot-from-S5, but not from S3 resume in this case. Would we expect the data to change in between? Also, my understanding was that once HECI is disabled, this information is unreliable (?), and that happens when coreboot sends the EndOfFirmware notification, which is at payload load time in the S5 boot path.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34616
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I86bc6e33de4096f33023730ffabb25715c985de0
Gerrit-Change-Number: 34616
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 29 Jul 2019 19:13:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment