Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42144 )
Change subject: mb/google/poppy: Drop VARIANT_SPECIFIC_OPTIONS_*
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42144/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42144/1//COMMIT_MSG@9
PS1, Line 9: Putting variant-specific options in Kconfig.name seems to be what is
: popular now
wasn't suggesting we get rid of it, just noting that it makes it much harder to figure out which boa […]
Right, I don't know if we can "expand" the symbols later on in Kconfig. I'll try that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42144
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8ce3237ac620c26856b6cf3d08293729641dd0b0
Gerrit-Change-Number: 42144
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 07 Jun 2020 18:45:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment