Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/11791 )
Change subject: mainboard/lenovo/t410: Add new port
......................................................................
Patch Set 15:
(2 comments)
https://review.coreboot.org/c/coreboot/+/11791/15/src/mainboard/lenovo/t410/...
File src/mainboard/lenovo/t410/mainboard.c:
https://review.coreboot.org/c/coreboot/+/11791/15/src/mainboard/lenovo/t410/...
PS15, Line 33: static void mainboard_init(struct device *dev)
I think this RCBA configuration may be removed. See commit b236cba61558649791224cf35357568bfe3b30db.
https://review.coreboot.org/c/coreboot/+/11791/15/src/mainboard/lenovo/t410/...
File src/mainboard/lenovo/t410/smihandler.c:
https://review.coreboot.org/c/coreboot/+/11791/15/src/mainboard/lenovo/t410/...
PS15, Line 21: #include <southbridge/intel/ibexpeak/pch.h>
I believe this include is no longer necessary since commit 548f33a9f4a7675c42822516c285bdf2c8bb64de
--
To view, visit
https://review.coreboot.org/c/coreboot/+/11791
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9d872e643dd242e925bfb46d18076e6ad100995
Gerrit-Change-Number: 11791
Gerrit-PatchSet: 15
Gerrit-Owner: Nicolas Reinecke
nr@das-labor.org
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nicolas Reinecke
nr@das-labor.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eloy Degen
Gerrit-CC: Matt Parnell
mparnell@gmail.com
Gerrit-CC: Okashi Odayakana
okashi@okashi.me
Gerrit-CC: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Comment-Date: Sat, 14 Sep 2019 15:42:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment