Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34501 )
Change subject: Framework to get settings from RW_VPD to configure FSP UPD ......................................................................
Patch Set 10:
(1 comment)
Patch Set 10:
(18 comments)
Patch Set 10:
I need some guidance here. This patch breaks some boards. If USE_FSP_1_0 is defined, the code looks for HyperThreading member in "struct _UPD_DATA_REGION". There are 10 boards either does not have such member in the struct, or does not have fsp.h defined. https://qa.coreboot.org/job/coreboot-gerrit/99551/.
Since my interest is OCP MonoLake board, I could make the framework effective for this board only; however, if possible it is better to have the framework as a library (eg. in src/drivers/vpd).
Thanks, Jonathan
That is because you mix FSP1.0 with Broadwell DE. Please move the Broadwell DE specific parts to src/soc/intel/fsp_boardwell_de/. src/drivers should not contain platform specific code.
https://review.coreboot.org/c/coreboot/+/34501/10/src/soc/intel/fsp_broadwel... File src/soc/intel/fsp_broadwell_de/fsp/chipset_fsp_util.c:
https://review.coreboot.org/c/coreboot/+/34501/10/src/soc/intel/fsp_broadwel... PS10, Line 129: board_fsp_configure_upd_data(UpdData); there's already romstage_fsp_rt_buffer_callback(). No need for another weak function.