Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40925 )
Change subject: Documentation/mb/ocp/tiogapass: Add documentation ......................................................................
Patch Set 3:
(7 comments)
https://review.coreboot.org/c/coreboot/+/40925/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40925/3//COMMIT_MSG@7 PS3, Line 7: Documentation
Doc
Done
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... File Documentation/mainboard/ocp/tiogapass.md:
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... PS3, Line 26: priviledge
privilege
Done
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... PS3, Line 30: Linuxboot binary
You can compile that from source. It's not a blob.
I did not want to imply it is a blob. I changed the wording from "binary" to "image".
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... PS3, Line 38: not verified
Huh?
Yes, we have not tried to run flashrom tool from OS.
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... PS3, Line 42: OpenBMC
If you are using the BMC to flash coreboot, that is considered internal programming. […]
Done. Oh, okay, so Out-Of-Band is part of internal programming. Since there is nothing special about external programming, I removed this section.
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... PS3, Line 85: SoC
Why not call it CPU or processor? Intel uses "Processor": […]
Done
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... PS3, Line 87: 2500
AST2500
Done