build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41895 )
Change subject: mb/google/volteer: Convert static ASL files to new DPTF implementation ......................................................................
Patch Set 9:
(15 comments)
https://review.coreboot.org/c/coreboot/+/41895/9/src/drivers/intel/dptf/chip... File src/drivers/intel/dptf/chip.h:
https://review.coreboot.org/c/coreboot/+/41895/9/src/drivers/intel/dptf/chip... PS9, Line 9: #define DPTF_PASSIVE(src,tgt,tmp,prd) \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/41895/9/src/drivers/intel/dptf/chip... PS9, Line 9: #define DPTF_PASSIVE(src,tgt,tmp,prd) \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/41895/9/src/drivers/intel/dptf/chip... PS9, Line 9: #define DPTF_PASSIVE(src,tgt,tmp,prd) \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/41895/9/src/drivers/intel/dptf/chip... PS9, Line 10: {.source=DPTF_##src, .target=DPTF_##tgt, .temp=tmp, .period=prd} spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/41895/9/src/drivers/intel/dptf/chip... PS9, Line 10: {.source=DPTF_##src, .target=DPTF_##tgt, .temp=tmp, .period=prd} spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/41895/9/src/drivers/intel/dptf/chip... PS9, Line 10: {.source=DPTF_##src, .target=DPTF_##tgt, .temp=tmp, .period=prd} spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/41895/9/src/drivers/intel/dptf/chip... PS9, Line 10: {.source=DPTF_##src, .target=DPTF_##tgt, .temp=tmp, .period=prd} spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/41895/9/src/drivers/intel/dptf/chip... PS9, Line 11: #define DPTF_CRITICAL(src,tmp,typ) \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/41895/9/src/drivers/intel/dptf/chip... PS9, Line 11: #define DPTF_CRITICAL(src,tmp,typ) \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/41895/9/src/drivers/intel/dptf/chip... PS9, Line 12: {.source=DPTF_##src, .temp=tmp, .type=DPTF_CRITICAL_##typ} spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/41895/9/src/drivers/intel/dptf/chip... PS9, Line 12: {.source=DPTF_##src, .temp=tmp, .type=DPTF_CRITICAL_##typ} spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/41895/9/src/drivers/intel/dptf/chip... PS9, Line 12: {.source=DPTF_##src, .temp=tmp, .type=DPTF_CRITICAL_##typ} spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/41895/9/src/drivers/intel/dptf/chip... PS9, Line 13: #define TEMP_PCT(t,r) {.temp=t, .fan_pct=r} space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/41895/9/src/drivers/intel/dptf/chip... PS9, Line 13: #define TEMP_PCT(t,r) {.temp=t, .fan_pct=r} spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/41895/9/src/drivers/intel/dptf/chip... PS9, Line 13: #define TEMP_PCT(t,r) {.temp=t, .fan_pct=r} spaces required around that '=' (ctx:VxV)